Procfile.example - add workers needed for embedded ansible #16679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checked commit https://github.com/himdel/manageiq/commit/afaaf8e2c6243cffc5005747aece36358e9bda02 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0 |
bdunne
reviewed
Dec 18, 2017
| @@ -49,6 +49,12 @@ | |||
| # vmware_event_<id>: ruby lib/workers/bin/run_single_worker.rb --ems-id <id> ManageIQ::Providers::Vmware::InfraManager::EventCatcher | |||
| # vmware_refresh_core_<id>: ruby lib/workers/bin/run_single_worker.rb --ems-id <id> MiqEmsRefreshCoreWorker | |||
|
|
|||
| # Embedded Ansible workers | |||
|
|
|||
| # ansible: ruby lib/workers/bin/run_single_worker.rb EmbeddedAnsibleWorker | |||
There was a problem hiding this comment.
Should this be embedded_ansible?
There was a problem hiding this comment.
This is the first time I'm seeing this file, you tell me ;) Should it?
There was a problem hiding this comment.
Nope, this is good as is.
It should be the name of the worker class.
simaishi
pushed a commit
that referenced
this pull request
Dec 19, 2017
Procfile.example - add workers needed for embedded ansible (cherry picked from commit 997f6d4)
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(created because https://github.com/ManageIQ/guides/pull/276/files#r156100289)
This adds the 3 workers needed to get Embedded Ansible working.
For details, please check ManageIQ/guides#276.
Cc @bdunne